-
-
Notifications
You must be signed in to change notification settings - Fork 389
Cabal autogen-modules and autogen-includes completion #4534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for the PR! |
71c918b
to
3dd647a
Compare
Hi, I updated the changes to reflect on top of the current master branch and added tests as well. Please let me know if there's anything else you'd like me to change! the tests can be run with: |
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Data.hs
Outdated
Show resolved
Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Data.hs
Outdated
Show resolved
Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Data.hs
Outdated
Show resolved
Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Data.hs
Outdated
Show resolved
Hide resolved
Hello, I've made the requested changes. I apologize for some of the unnecessary edits, I think when I was updating to the latest version some changes got lost. I have reverted them back. Please let me know if there is an issue with anything else, and thank you for your patience. |
I have caught an error in my commit. My apologies, am fixing it right now. I'm still not quite sure by what you meant about adding autogen-modules to libExecTestBenchCommons? |
Looks good to me now, if the CI is green I think we can merge :) |
Sounds great, thank you for checking! I've renamed the directory :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me!
Added support for the autogen-modules: field in .cabal file completions inside library, executable, test-suite, and benchmark stanzas and autogen-includes in all relevant stanza types via libExecTestBenchCommons.
Behavior was tested manually in a cabal file.
Closes #4526