Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ghcide-test to stand alone dir #4520

Merged
merged 10 commits into from
Mar 19, 2025
Merged

Move ghcide-test to stand alone dir #4520

merged 10 commits into from
Mar 19, 2025

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Mar 17, 2025 •
edited
Loading

address #4519

@soulomoon soulomoon linked an issue Mar 17, 2025 that may be closed by this pull request
prepare HLS for 9.12: move ghcide-test to a stand-along dir #4519
Closed
@soulomoon soulomoon marked this pull request as ready for review March 17, 2025 07:24
@soulomoon
Copy link
Collaborator Author

Mainly some unfinished business refactoring the ghcide test.

Two things are done.

Move ghcide test files to a more correct location, a stand alone dir away from ghcide.
Move ghcide-test-preprocess to haskell-language-server.cabal. And move it out of ghcide too.

cc @michaelpj @fendor

@soulomoon soulomoon enabled auto-merge (squash) March 17, 2025 07:33
@soulomoon soulomoon disabled auto-merge March 17, 2025 08:00
@soulomoon soulomoon requested a review from fendor March 17, 2025 08:29
@soulomoon
Copy link
Collaborator Author

Ready to go

fendor
fendor requested changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM!

@soulomoon soulomoon requested a review from fendor March 18, 2025 10:21
@fendor fendor enabled auto-merge (squash) March 18, 2025 10:39
@fendor fendor merged commit 111ad4c into master Mar 19, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@michaelpj michaelpj Awaiting requested review from michaelpj michaelpj is a code owner

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prepare HLS for 9.12: move ghcide-test to a stand-along dir
2 participants
@soulomoon @fendor