Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple the session loader into reader and writer over the cache #4445

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from
+251 −66
Draft

Decouple the session loader into reader and writer over the cache #4445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
58b8b68
Refactor session loading to manage pending files so we can batch load…
soulomoon Nov 2, 2024
ea002d7
distribute errors to all pending files are being loading
soulomoon Nov 3, 2024
c78b197
better filter loading files
soulomoon Nov 3, 2024
b879375
fallback to non-batch load
soulomoon Nov 4, 2024
8953aec
typo
soulomoon Nov 4, 2024
4bdc2c8
update inline doc
soulomoon Nov 4, 2024
c4bb53a
update inline doc
soulomoon Nov 4, 2024
112bc95
add LogSessionReloadOnError to log errors during file reloads; cleanu…
soulomoon Nov 4, 2024
9a2aaf1
Merge branch 'master' into batch-load
soulomoon Nov 4, 2024
6e04d28
refactor loadSessionWithOptions to improve error handling and clarify…
soulomoon Nov 4, 2024
67aebc4
refactor loadSessionWithOptions to improve pending file handling and …
soulomoon Nov 4, 2024
98ae446
add doc about limitation
soulomoon Nov 4, 2024
f3eb580
absolute file at the beginning
soulomoon Nov 5, 2024
e7bd3d4
run session loader and worker in sperate
soulomoon Nov 7, 2024
1f97c40
cleanup
soulomoon Nov 7, 2024
4c998bd
rename LogGetSessionRetry to LogLookupSessionCache for clarity in log…
soulomoon Nov 8, 2024
79a43a0
extract attempt to load files from errors
soulomoon Nov 9, 2024
beb1764
refactor session loading to wait for pending files before cache check
soulomoon Nov 12, 2024
6139522
add LogTime to logging for improved time tracking during session loading
soulomoon Nov 18, 2024
7314509
refactor session loading to handle dependency checks more clearly
soulomoon Nov 19, 2024
cddcc55
Refactors session loading logic
soulomoon Nov 19, 2024
4c99c47
Merge branch 'master' into batch-load-multi-read
soulomoon Dec 6, 2024
bb78a36
delay the restart
soulomoon Dec 6, 2024
33f788c
Merge branch 'master' into batch-load-multi-read
soulomoon Jan 8, 2025
0913d2e
Merge branch 'master' into batch-load-multi-read
soulomoon Feb 4, 2025
58ec7ea
re-inline the old file instead of loading it twice
soulomoon Feb 17, 2025
60e8427
Merge branch 'master' into batch-load-multi-read
soulomoon Feb 17, 2025
d943963
update upload artifact action version
soulomoon Feb 18, 2025
5d01500
update hie-bios tag
soulomoon Feb 25, 2025
10a6f7e
Update hie-bios tag to latest commit
soulomoon Feb 26, 2025
de6d5f3
Merge branch 'master' into batch-load-multi-read
soulomoon Mar 2, 2025
45b1241
update hie-bios
soulomoon Mar 2, 2025
219db46
update index-state to reflect the latest project state
soulomoon Mar 2, 2025
2f86db0
update index-state to reflect the new date
soulomoon Mar 3, 2025
de98232
update fourmolu dependency version constraints
soulomoon Mar 6, 2025
f0a881d
remove ListT from library dependencies
soulomoon Mar 6, 2025
14f6a3b
update hie-bios to a new tag
soulomoon Mar 6, 2025
8b0e246
update fourmolu dependency version constraints to allow 0.16
soulomoon Mar 6, 2025
2dd71c0
add allow-newer constraint for Cabal-syntax
soulomoon Mar 6, 2025
b8406d6
remove allow-newer constraint for Cabal-syntax
soulomoon Mar 6, 2025
5ea3d87
bump actions/checkout and actions/upload-artifact to v3
soulomoon Mar 6, 2025
3e0c27b
Revert "bump actions/checkout and actions/upload-artifact to v3"
soulomoon Mar 6, 2025
8c27e34
add allow-older constraint for optparse-applicative in cabal.project
soulomoon Mar 7, 2025
bb0a541
Merge branch 'master' into batch-load-multi-read
soulomoon Mar 13, 2025
e491f60
Merge branch 'master' into batch-load-multi-read
soulomoon Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cabal.project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,10 @@ if impl(ghc >= 9.8.4) && impl(ghc < 9.8.5)
ghc-lib-parser:filepath
constraints:
ghc-lib-parser==9.8.4.20241130

source-repository-package
type: git
location: https://github.com/haskell/hie-bios
tag: 65df091a4464b43043661d70c1dcfed1ed1fa9a9
-- see https://github.com/haskell/haskell-language-server/pull/4445#issuecomment-2705787655
allow-older: hie-bios:optparse-applicative
1 change: 1 addition & 0 deletions ghcide/ghcide.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ library
Development.IDE.GHC.CPP
Development.IDE.GHC.Warnings
Development.IDE.Types.Action
Development.IDE.Session.OrderedSet

if flag(pedantic)
ghc-options:
Expand Down
Loading
Loading