-
Notifications
You must be signed in to change notification settings - Fork 710
Bump dependency on process #8279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It turns out that process-1.6.14.0 depends on base-4.10 (so GHC 8.2). (That lower bound came with this PR and is probably not due to incompatibility, but just because CI doesn't test GHC versions earlier than 8.2.) |
I think we are going to need another RC, in which case there's going to be enough time to dogfood (and userfood) this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's brave so late in the release process, but seems unavoidable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks, let's see what is the behaviour in Windows (not sure when I will have time to give a try)
@@ -9,6 +9,15 @@ | |||
"source": "local", | |||
"version": "3.9.0.0" | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow some way to generate this auto would be handy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is auto-generated with make update-bootstrap-jsons
or something like that. But, if we are lukcy, a backport is going to be easier with the small change.
This is guarded to be for GHC from 8.2 only, since the process release depends on base-4.10. Includes an update to the bootstrapping files.
5099499
to
f9475d4
Compare
@Mergifyio backport 3.8 |
✅ Backports have been created
|
Bump dependency on process (backport #8279)
I've just tried cabal from https://gitlab.haskell.org/haskell/cabal/-/jobs/1108769 and I no longer see the spurious process messages. Was worth it. :) |
It seems we need to bump up the process package one notch again due to NorfairKing/feedback#2 I think it's not grave enough to derail 3.8.1.0, but let's backport for the benefit of the hypothetical 3.8.2.0. |
Let me do that in a new PR. |
Compare the discussion in #8208.