Raise process lower bound to 1.2.1.0 #7922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find re #7534, That confirms the "support window" permits this upgrade. |
robx
commented
Jan 22, 2022
Cabal/Cabal.cabal
Outdated
| @@ -96,7 +96,6 @@ library | |||
| Distribution.Utils.MD5 | |||
| Distribution.Utils.String | |||
| Distribution.Utils.Structured | |||
| Distribution.Compat.CreatePipe | |||
There was a problem hiding this comment.
We could keep Distribution.Compat.CreatePipe as a trivial reexport to avoid requiring library users to make changes here if they were using the module. And/or I guess this module going away should be documented explicitly in the Changelog?
There was a problem hiding this comment.
If it's so cheap, I'd say let's keep the compat. The PR breaks (legally) enough stuff.
andreasabel
reviewed
Jan 22, 2022
Mikolaj
approved these changes
Jan 25, 2022
andreasabel
approved these changes
Jan 25, 2022
andreasabel
added
re: code quality
|
@robx: would you like to merge? If so, add the merge_me label (it rebases, etc.). Thank you for the PR! |
process-1.2.1.0 was released in Dec 2014.
Keep Distribution.Compat.CreatePipe as a trivial reexport to avoid changing the published API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into these shims while working on #7921. Do I interpret the "support window" info right in that we can do this?
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!