-
Notifications
You must be signed in to change notification settings - Fork 67
Add [email protected]
documentation
#943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vercel Previews Deployed
|
Broken Link CheckerNo broken links found! 🎉 |
[email protected]
documentation[email protected]
documentation
8fae197
to
5c74f9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀, I left some nit comments but since our docs can be updated after release, they can always be addressed in a follow-up.
The following pre-requisites are required to implement `list` for an SDKv2 resource: | ||
|
||
1. The provider must be able to access framework functionality, this can be achieved by [combining providers](/terraform/plugin/mux/combining-protocol-version-5-providers) | ||
1. The list resource type needs to be added to the provider so that it is available to practitioners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It might help to explicitly mention that the list resource is added to the "framework" provider (I think that's kind of assumed, since it's impossible to add anything to SDKv2 for it)
content/terraform-plugin-sdk/v2.38.x/docs/plugin/sdkv2/resources/list.mdx
Outdated
Show resolved
Hide resolved
content/terraform-plugin-sdk/v2.38.x/docs/plugin/sdkv2/resources/list.mdx
Outdated
Show resolved
Hide resolved
Also LGTM |
560a930
to
1978acb
Compare
This PR adds the documentation for the not yet released v2.38.0 of the terraform-plugin-sdk