Fix mfa argument + backport #1104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport for 1.19.x till 1.21.x
… till 1.21.x This way, customers who are looking for Single-Phase login using MFA can find both API and CLI methods of doing it on one page.
Vercel Previews Deployed
|
Broken Link CheckerNo broken links found! 🎉 |
schavis
requested changes
Oct 14, 2025
Comment on lines
+111
to
+113
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | ||
|
|
||
| **Examples**: |
There was a problem hiding this comment.
Suggested change
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | |
| **Examples**: | |
| Use the `-mfa` CLI flag or `VAULT_MFA` environment variable to pass in MFA credentials. For example: |
Style correction: write simply
Comment on lines
+111
to
+113
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | ||
|
|
||
| **Examples**: |
There was a problem hiding this comment.
Suggested change
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | |
| **Examples**: | |
| Use the `-mfa` CLI flag or `VAULT_MFA` environment variable to pass in MFA credentials. For example: |
Edited to match original suggestion
Comment on lines
+111
to
+113
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | ||
|
|
||
| **Examples**: |
There was a problem hiding this comment.
Suggested change
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | |
| **Examples**: | |
| Use the `-mfa` CLI flag or `VAULT_MFA` environment variable to pass in MFA credentials. For example: |
Edited to match original suggestion
Comment on lines
+111
to
+113
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | ||
|
|
||
| **Examples**: |
There was a problem hiding this comment.
Suggested change
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | |
| **Examples**: | |
| Use the `-mfa` CLI flag or `VAULT_MFA` environment variable to pass in MFA credentials. For example: |
Edited to match original suggestion
Comment on lines
+115
to
+117
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | ||
|
|
||
| **Examples**: |
There was a problem hiding this comment.
Suggested change
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | |
| **Examples**: | |
| Use the `-mfa` CLI flag or `VAULT_MFA` environment variable to pass in MFA credentials. For example: |
Edited to match original suggestion
Comment on lines
+115
to
+117
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | ||
|
|
||
| **Examples**: |
There was a problem hiding this comment.
Suggested change
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | |
| **Examples**: | |
| Use the `-mfa` CLI flag or `VAULT_MFA` environment variable to pass in MFA credentials. For example: |
Edited to match original suggestion
Comment on lines
+115
to
+117
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | ||
|
|
||
| **Examples**: |
There was a problem hiding this comment.
Suggested change
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | |
| **Examples**: | |
| Use the `-mfa` CLI flag or `VAULT_MFA` environment variable to pass in MFA credentials. For example: |
Edited to match original suggestion
Comment on lines
+116
to
+118
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | ||
|
|
||
| **Examples**: |
There was a problem hiding this comment.
Suggested change
| For CLI, you need to make use of the `-mfa` flag or `VAULT_MFA` environment variable to pass in the MFA credentials. | |
| **Examples**: | |
| Use the `-mfa` CLI flag or `VAULT_MFA` environment variable to pass in MFA credentials. For example: |
Edited to match original suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #1013
Fixed
-mfaargument for CLI flags since it was incorrect.Also added this CLI flag description to the Single-Phase login docs so customers who are looking for Single-Phase MFA login can now find how to do it via API and CLI on one page (reduces confusion).