-
Notifications
You must be signed in to change notification settings - Fork 88
Fix TFE_REDIS_USE_MTLS heading. Add example for TFE_OBJECT_STORAGE_S3_ENDPOINT #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixed TFE_REDIS_USE_MTLS heading. On TFE version v202507-1 and later, TFE_OBJECT_STORAGE_S3_ENDPOINT requires the protocol, added an example.
fixed formatting
On TFE version v202507-1 and later, TFE_OBJECT_STORAGE_S3_ENDPOINT requires the protocol, added an example.
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Vercel Previews Deployed
|
Broken Link CheckerNo broken links found! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added a small style suggestion!
default AWS S3 endpoint. Defaults to `""`. | ||
S3 endpoint. Useful when using a private S3 endpoint. | ||
|
||
Example: `TFE_OBJECT_STORAGE_S3_ENDPOINT: https://s3.example.com` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I can't add this as a suggestion because the markdown breaks, but could you tweak this to explain the example a bit like so:
The following example sets your S3 endpoint to a private S3 endpoint named https://s3.example.com
:
TFE_OBJECT_STORAGE_S3_ENDPOINT: https://s3.example.com
default AWS S3 endpoint. Defaults to `""`. | ||
S3 endpoint. Useful when using a private S3 endpoint. | ||
|
||
Example: `TFE_OBJECT_STORAGE_S3_ENDPOINT: https://s3.example.com` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment!
The following example sets your S3 endpoint to a private S3 endpoint named https://s3.example.com
:
TFE_OBJECT_STORAGE_S3_ENDPOINT: https://s3.example.com
On v1.0.x
https://support.hashicorp.com/hc/en-us/articles/45050543253779-S3-Endpoint-is-not-a-valid-URI-TFE-v202507-1-and-later
On v202507-1
https://support.hashicorp.com/hc/en-us/articles/45050543253779-S3-Endpoint-is-not-a-valid-URI-TFE-v202507-1-and-later