Default Vault Auth Role To Lambda Name#17
Open
abrucker235 wants to merge 1 commit intohashicorp:mainfrom
Open
Conversation
|
|
Contributor
|
Hey @abrucker235 - thanks for the contribution here! I admit I'm reluctant to merge this however without knowing if this is a common pattern for our users, or if it's particular to your specific usage patterns. I hope that makes sense. |
Author
|
@catsby this might be a pattern we use and I can see the hesitation, but its a pattern I feel helps encourage not reusing vault roles across different lambdas and practice least access. Technically this doesn't turn off the original capability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed it so that consumers could create auth roles based on lambda name and don't have to set additional variable unless they want it to be called different.