feat: add extra annotations to customize path of injected token and permissions of the token file sink on vault #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermissions of the token file sink on vault
adds:
* `vault.hashicorp.com/agent-inject-token-file` to specify a different
path other than `${vault_volume_name}/token`
* `vault.hashicorp.com/agent-inject-token-perms` to specify a different
permission for the token file, other than the current default, 0640
srevinsaju
force-pushed
the
feature/vault-token-annotations-customization
branch
from
84762d7
to
9db0d8a
Compare
|
This would be great. Ran into some trouble with this issue using a distroless container this week. Is this linked to a feature request or github issue? |
|
nope, it’s currently not linked to a feature request/issue right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds:
vault.hashicorp.com/agent-inject-token-fileto specify a different path other than${vault_volume_name}/tokenvault.hashicorp.com/agent-inject-token-permsto specify a different permission for the token file, other than the current default, 0640