Add VirtualBox 7.1.x Support

[hswong3i]

With some simple regex + manual confirmation, e.g. find . -type f | xargs fgrep -nH '7.0'

Also reference changes from #12953 and #13046

Fixes #13501

[egel]

thanks @hswong3i for PR! It would be great to add soon the support for [email protected]! 😁

I am not familiar with code repo but I am wondering what still needs to be done to deliver this feature except fixing the tests?

PS. I've landed here from #13501 as on macOS M1 there is currently no other option (known to me) to use vagrant - as the trick with modifying /usr/local/bin/VBoxManage did not work for me.

[koppor]

Reading the test output, maybe more has to be done?

 Failed examples:

rspec ./test/unit/plugins/providers/virtualbox/driver/version_7_1_test.rb:200 # VagrantPlugins::ProviderVirtualBox::Driver::Version_7_1#read_bridged_interfaces when hostonlynets are enabled should return all interfaces in list
rspec ./test/unit/plugins/providers/virtualbox/driver/version_7_1_test.rb:213 # VagrantPlugins::ProviderVirtualBox::Driver::Version_7_1#read_bridged_interfaces when hostonlynets are enabled when hostonly networks are defined should not return all interfaces in list
rspec ./test/unit/plugins/providers/virtualbox/driver/version_7_1_test.rb:217 # VagrantPlugins::ProviderVirtualBox::Driver::Version_7_1#read_bridged_interfaces when hostonlynets are enabled when hostonly networks are defined should not include hostonly network devices

[sergeypayu]

it was actual only for the 7.0.0 release and is not needed here

[sergeypayu]

in fact, the only code you need is:

# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: BUSL-1.1

require File.expand_path("../version_7_0", __FILE__)

module VagrantPlugins
  module ProviderVirtualBox
    module Driver
      # Driver for VirtualBox 7.1.x
      class Version_7_1 < Version_7_0
        def initialize(uuid)
          super

          @logger = Log4r::Logger.new("vagrant::provider::virtualbox_7_1")
        end
      end
    end
  end
end

this will also fix the tests errors, since they are failed due to constant redefinition (like HOSTONLY_NET_REQUIREMENT)

[billerby]

Hi @hswong3i, I noticed the reviewer has provided the exact changes needed for this PR. Since the modifications are already specified, I'd be happy to quickly implement these requested changes if you're currently busy with other commitments. Would you prefer to make these updates yourself, or would you be open to having someone help move this forward?

Noticed there is actually a new one implementing it the way its proposed by @sergeypayu
#13513

[slonopotamus]

There already exists #13513

[hswong3i]

Hi @hswong3i, I noticed the reviewer has provided the exact changes needed for this PR. Since the modifications are already specified, I'd be happy to quickly implement these requested changes if you're currently busy with other commitments. Would you prefer to make these updates yourself, or would you be open to having someone help move this forward?

Noticed there is actually a new one implementing it the way its proposed by @sergeypayu #13513

There are some minor missing from #13513 and I had counter propose for it.

Anyway, work could go with #13513, let's close this ;-)