-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added "strategy.rolling_update.max_surge" argument to kubernetes_daemon_set_v1
#2609
Open
theonlyames
wants to merge
8
commits into
hashicorp:main
Choose a base branch
from
theonlyames:max_surge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
theonlyames
changed the title
Updated Kubernetes Daemonset RollingUpdate to support the maxSurge pr…
feat: added "strategy.rolling_update.max_surge" argument to Oct 24, 2024
kubernetes_daemon_set_v1
2 tasks
BBBmau
reviewed
Oct 24, 2024
BBBmau
reviewed
Oct 24, 2024
This reverts commit d951b28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the rollingUpdate.maxSurge property for DaemonSets. See #2106
There is admittedly already a PR for this (PR #2416), but that is slightly out of date in terms of the documentation structure and I started this branch before I realized it existed.
Acceptance tests
Output from acceptance testing:
I am currently struggling to actually run any of the makefile builds, which may be due to something in my WSL setup.
Release Note
Release note for CHANGELOG:
References
Related Issue: #2106
Terraform documentation: https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/daemonset#rolling_update
Kubernetes documentation: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#:~:text=updateStrategy.rollingUpdate.-,maxSurge,-(IntOrString)
Community Note