Skip to content

Conversation

0xThresh
Copy link

Rollback Plan

If a change needs to be reverted, simply revert the PR to remove documentation updates.

Changes to Security Controls

N/A

Description

Opened in response to #44758. This is only a fix for docs to ensure that the example for the aws_bedrockagent_agent resource works; there are other underlying issues to fix regarding whether the instructions input should be optional.

Relations

Relates #44758

References

Issue linked above

Output from Acceptance Testing

make docs
make: Documentation Checks / markdown-link-check...
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
/usr/local/lib
+-- [email protected]
`-- [email protected]
  +-- @isaacs/[email protected]
  +-- @npmcli/[email protected]
  +-- @npmcli/[email protected]
  +-- @npmcli/[email protected]
  +-- @npmcli/[email protected]
  +-- @npmcli/[email protected]
  +-- @npmcli/[email protected]
  +-- @npmcli/[email protected]
  +-- @npmcli/[email protected]
  +-- @sigstore/[email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  +-- [email protected]
  `-- [email protected]

::endgroup::
Using markdown-link-check configuration file: /markdown/.ci/.markdownlinkcheck.json
QUIET: yes
VERBOSE: yes
DIRECTORY: /markdown/docs
DEPTH: -1
MODIFIED: no
BRANCH: main
PREFIX: 
EXTENSION: .md
FILE: 
+ find /markdown/docs -name '*.md' -not -path './node_modules/*' -exec markdown-link-check '{}' --config /markdown/.ci/.markdownlinkcheck.json -q -v ';'
+ set +x
=========================> MARKDOWN LINK CHECK <=========================

[✔] All links are good!

=========================================================================
make: Documentation Checks / markdown-lint...
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
make: Documentation Checks / misspell...
make: misspell: No such file or directory
make: *** [docs-misspell] Error 1

I promise I double-checked for misspellings since I couldn't get the last test to work.

@0xThresh 0xThresh requested a review from a team as a code owner October 21, 2025 20:05
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XS Managed by automation to categorize the size of a PR. labels Oct 21, 2025
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of any other updates that we might make based on the comment I left on your issue, this change seems reasonable to me, to at least make the example work properly. Thank you for taking the time to raise this!

@0xThresh 0xThresh changed the title fix(docs): Add instruction input to AgentCore Agent example fix(docs): Add instruction input to BedRock Agent example Oct 22, 2025
@jar-b
Copy link
Member

jar-b commented Oct 23, 2025

Going to close this out in favor of the recently merged #44771 which updated the example as well as the instruction argument description with additional context on when it becomes required.

Nonetheless thank you for your submission @0xThresh! 👍

@jar-b jar-b closed this Oct 23, 2025
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Oct 23, 2025
@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants