Skip to content

Conversation

@ramonvermeulen
Copy link
Contributor

@ramonvermeulen ramonvermeulen commented Oct 20, 2025

Rollback Plan

N/A

Changes to Security Controls

N/A

Description

Adds the ability to enable directory data access via the provider.

Relations

Closes #44636

References

https://docs.aws.amazon.com/cli/latest/reference/ds/enable-directory-data-access.html
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directoryservice#Client.DescribeDirectoryDataAccess
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directoryservice#Client.EnableDirectoryDataAccess
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directoryservice#Client.DescribeDirectoryDataAccess

Output from Acceptance Testing

Test execution:

make testacc TESTS=TestAccDSDirectory_enableDirectoryDataAccess PKG=ds

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f/44636-enable-directory-data-access 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/ds/... -v -count 1 -parallel 20 -run='TestAccDSDirectory_enableDirectoryDataAccess'  -timeout 360m -vet=off
2025/10/22 10:01:46 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/22 10:01:46 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDSDirectory_enableDirectoryDataAccess
=== PAUSE TestAccDSDirectory_enableDirectoryDataAccess                                                                                                                                        --- PASS: TestAccDSDirectory_enableDirectoryDataAccess (1825.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ds 1830.293s

@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ds Issues and PRs that pertain to the ds service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Oct 20, 2025
@ramonvermeulen ramonvermeulen force-pushed the f/44636-enable-directory-data-access branch from b72833d to 1e7a7b9 Compare October 21, 2025 15:08
@ramonvermeulen ramonvermeulen force-pushed the f/44636-enable-directory-data-access branch from 6e7259f to cfdd1f0 Compare October 21, 2025 15:29
@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Oct 21, 2025
@ramonvermeulen ramonvermeulen changed the title feat(directory): initial draft for enable-directory-data-access feat(directory): add argument enable-directory-data-access to aws_directory_service_directory Oct 21, 2025
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Oct 22, 2025
@ramonvermeulen ramonvermeulen marked this pull request as ready for review October 22, 2025 08:40
@ramonvermeulen ramonvermeulen requested a review from a team as a code owner October 22, 2025 08:40
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@ramonvermeulen ramonvermeulen changed the title feat(directory): add argument enable-directory-data-access to aws_directory_service_directory feat(directory): add argument enable_directory_data_access to aws_directory_service_directory Oct 22, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ds Issues and PRs that pertain to the ds service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add parameter for enable-directory-data-access to aws_directory_service_directory

2 participants