-
Notifications
You must be signed in to change notification settings - Fork 9.8k
feat(directory): add argument enable_directory_data_access to aws_directory_service_directory
#44736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ramonvermeulen
wants to merge
12
commits into
hashicorp:main
Choose a base branch
from
ramonvermeulen:f/44636-enable-directory-data-access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(directory): add argument enable_directory_data_access to aws_directory_service_directory
#44736
ramonvermeulen
wants to merge
12
commits into
hashicorp:main
from
ramonvermeulen:f/44636-enable-directory-data-access
+240
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
b72833d to
1e7a7b9
Compare
6e7259f to
cfdd1f0
Compare
enable-directory-data-accessenable-directory-data-access to aws_directory_service_directory
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
enable-directory-data-access to aws_directory_service_directoryenable_directory_data_access to aws_directory_service_directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
enhancement
Requests to existing resources that expand the functionality or scope.
service/ds
Issues and PRs that pertain to the ds service.
size/L
Managed by automation to categorize the size of a PR.
size/M
Managed by automation to categorize the size of a PR.
size/S
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
N/A
Changes to Security Controls
N/A
Description
Adds the ability to enable directory data access via the provider.
Relations
Closes #44636
References
https://docs.aws.amazon.com/cli/latest/reference/ds/enable-directory-data-access.html
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directoryservice#Client.DescribeDirectoryDataAccess
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directoryservice#Client.EnableDirectoryDataAccess
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directoryservice#Client.DescribeDirectoryDataAccess
Output from Acceptance Testing
Test execution: