-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): allow chaining of TerraformIterator created resources #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 17, 2023 16:00
c59f6a8
to
c278efe
Compare
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 17, 2023 16:05
c278efe
to
9d39fbd
Compare
ansgarm
reviewed
Nov 17, 2023
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 20, 2023 10:09
9d39fbd
to
5792382
Compare
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 20, 2023 10:44
5792382
to
a7bc1f7
Compare
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 20, 2023 12:32
a7bc1f7
to
0374555
Compare
📄 Content ChecksUpdated: Tue, 28 Nov 2023 14:40:00 GMT Found 20 error(s)
|
Position | Description | Rule |
---|---|---|
25048:301-25048:389 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
26308:226-26308:314 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
27315:310-27315:398 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
28569:226-28569:314 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
docs/cdktf/api-reference/go.mdx
Position | Description | Rule |
---|---|---|
25048:301-25048:389 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
26308:226-26308:314 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
27315:310-27315:398 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
28569:226-28569:314 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
docs/cdktf/api-reference/java.mdx
Position | Description | Rule |
---|---|---|
29274:301-29274:389 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
30534:226-30534:314 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
31541:310-31541:398 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
32795:226-32795:314 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
docs/cdktf/api-reference/python.mdx
Position | Description | Rule |
---|---|---|
30281:301-30281:389 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
31699:226-31699:314 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
32824:310-32824:398 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
34236:226-34236:314 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
docs/cdktf/api-reference/typescript.mdx
Position | Description | Rule |
---|---|---|
24443:301-24443:389 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
25703:226-25703:314 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
26710:310-26710:398 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
27964:226-27964:314 |
Unexpected product-relative link: /language/values/variables#suppressing-values-in-cli-output . Ensure that relative links are fully-qualified Developer paths: /{productSlug}/language/values/variables |
ensure-valid-link-format |
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 20, 2023 13:11
0374555
to
c6a9ebe
Compare
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 20, 2023 13:20
c6a9ebe
to
cf59c69
Compare
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 20, 2023 13:26
cf59c69
to
e6b486d
Compare
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 20, 2023 15:21
e6b486d
to
7c884b3
Compare
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 28, 2023 14:37
8dc4391
to
b388b88
Compare
Co-authored-by: Ansgar Mertens <[email protected]>
we fake them now for appearances, but the bindings used were old and keeping them in sync is an ongoing task otherwise
Co-authored-by: Ansgar Mertens <[email protected]>
Co-authored-by: Mutahhir Hayat <[email protected]>
DanielMSchmidt
force-pushed
the
proper-chained-iterators
branch
from
November 28, 2023 14:39
b388b88
to
65b2a60
Compare
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings both chaining iterators to the table as well as a mechanism to craft for expressions from iterators.
Closes #2024
Closes #1940