Skip to content

Commit

Permalink
fix: Use unique names to see if Github filters can pick it up (#3291)
Browse files Browse the repository at this point in the history
<!--

Unless this is a very simple 1-line-of-code change, please create a new
issue describing the change you're proposing first, then link to it from
this PR.

Read more about our process in our contributing guide:
https://github.com/hashicorp/terraform-cdk/blob/main/CONTRIBUTING.md

-->

### Description

Part of the Merge queue running the required checks, Github UI is still
not picking up the results job so try 2
  • Loading branch information
mutahhir authored Nov 23, 2023
1 parent 67620a1 commit 3bd1b8d
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/examples-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

jobs:
examples:
name: "Examples Integration Test - PR"
name: "Examples Integration Tests - PR"
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci/skip-examples') && !contains(github.event.pull_request.labels.*.name, 'ci/unit-only') }}
uses: ./.github/workflows/examples.yml
with:
Expand All @@ -22,7 +22,7 @@ jobs:
results:
if: ${{ always() }}
runs-on: ubuntu-latest
name: Result
name: "Examples Integration Tests - PR - Result"
needs: [examples]
steps:
- run: exit 1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
results:
if: ${{ always() }}
runs-on: ubuntu-latest
name: Result
name: "Integration Tests - PR - Result"
needs: [integration_test]
steps:
- run: exit 1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-provider-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
results:
if: ${{ always() }}
runs-on: ubuntu-latest
name: Result
name: "Provider Integration Tests - PR - Result"
needs: [provider_integration_test]
steps:
- run: exit 1
Expand Down
16 changes: 13 additions & 3 deletions .github/workflows/pr-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
jobs:
all_unit_tests:
name: "All Unit Tests"
if: ${{ contains(github.event.pull_request.labels.*.name, 'ci/run-unit') || contains(github.event.pull_request.labels.*.name, 'ci/run-all') }}
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci/skip-unit') }}
uses: ./.github/workflows/unit.yml
strategy:
fail-fast: false
Expand Down Expand Up @@ -138,8 +138,18 @@ jobs:
results:
if: ${{ always() }}
runs-on: ubuntu-latest
name: Result
needs: [all_unit_tests]
name: Unit Tests - PR - Result
needs:
[
all_unit_tests,
cdktf,
cdktf_cli,
cdktf_provider_generator,
cdktf_hcl2json,
cdktf_hcl2cdk,
cdktf_commons,
cdktf_cli_core,
]
steps:
- run: exit 1
if: >-
Expand Down

0 comments on commit 3bd1b8d

Please sign in to comment.