feat: support terraform_version_file
#454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
changed the title
terraform_version_file
|
|
README.md
Outdated
|
|
||
| If the `terraform_version_file` input is specified, the action will extract the version from the file and install it. | ||
|
|
||
| Supported files names are `.tool-versions` or anything else. |
There was a problem hiding this comment.
We use .terraform-version which is a quasi-standard for Terraform: https://github.com/tfutils/tfenv?tab=readme-ov-file#terraform-version-file.
There was a problem hiding this comment.
Do you mean replace or anything else. for .terraform-version?
I think keeping compatibility with https://github.com/asdf-vm/asdf by using .tool-versions is a good idea, for instance, some other GitHub actions use it:
There was a problem hiding this comment.
The Java action also supports .java-version: https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md.
I think it would be good to mention .terraform-version specifically because a lot of people are probably using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #298 and #208
What
Add support for
terraform_version_fileinput and keep the backward compatibility to uselatestif both inputs are set or onlyterraform_version.Why
Take advantage of the existing tools such as https://github.com/asdf-vm/asdf
Use a similar mechanism done in some other
setup-<app> actions.Similar PRs
I was blind, and I didn't see any references to them in the GH issues :/