Fix git url with ambiguous ref#382
Merged
CreatorHead merged 2 commits intohashicorp:mainfrom Jan 14, 2026
Merged
Conversation
|
|
CreatorHead
approved these changes
Jan 14, 2026
Contributor
CreatorHead
left a comment
CreatorHead
left a comment
There was a problem hiding this comment.
This is a minimal, surgical fix for handling ambiguous git references. The addition of -- to the git checkout command follows git best practices and prevents path/ref confusion when a reference could be interpreted as both a branch and tag.
The test case properly simulates the real-world scenario and confirms the fix resolves the issue without breaking existing workflows.
LGTM - Safe to merge. Well-tested fix for a legitimate edge case.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as in pull request #251 but with added test case.