Showcase: convert modifier/helper integration tests to gts or typescript #3366
+1,225
−991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
aklkv
reviewed
Nov 14, 2025
shleewhite
force-pushed
the
hds-5557/spike/convert-components-to-gts
branch
from
30be8eb to
179bcf0
Compare
Base automatically changed from
hds-5557/spike/convert-components-to-gts
to
main
November 19, 2025 14:51
shleewhite
force-pushed
the
hds-5581/helpers-modifiers-tests-gts
branch
from
2b65a92 to
f23eaf6
Compare
aklkv
force-pushed
the
hds-5581/helpers-modifiers-tests-gts
branch
from
0185f03 to
02f8b66
Compare
aklkv
force-pushed
the
hds-5581/helpers-modifiers-tests-gts
branch
from
02f8b66 to
86db065
Compare
aklkv
force-pushed
the
hds-5581/helpers-modifiers-tests-gts
branch
from
86db065 to
7a3bb2f
Compare
aklkv
force-pushed
the
hds-5581/helpers-modifiers-tests-gts
branch
from
7a3bb2f to
6b2568f
Compare
aklkv
force-pushed
the
hds-5581/helpers-modifiers-tests-gts
branch
from
6b2568f to
e7ee901
Compare
aklkv
force-pushed
the
hds-5581/helpers-modifiers-tests-gts
branch
from
e7ee901 to
3c27aca
Compare
aklkv
force-pushed
the
hds-5581/helpers-modifiers-tests-gts
branch
from
3c27aca to
e9f223d
Compare
aklkv
force-pushed
the
hds-5581/helpers-modifiers-tests-gts
branch
from
e9f223d to
b00132d
Compare
didoo
reviewed
Nov 20, 2025
Contributor
didoo
left a comment
didoo
left a comment
There was a problem hiding this comment.
Had a very quick look, not looked at every detail. Left only a comment.
| "@embroider/macros": "^1.18.1", | ||
| "@embroider/test-setup": "^4.0.0", | ||
| "@eslint/js": "^9.27.0", | ||
| "@floating-ui/dom": "^1.6.12", |
Contributor
There was a problem hiding this comment.
[issue?] why this is added here?
Contributor
Author
There was a problem hiding this comment.
Added because I needed to import the types for one of the tests: https://github.com/hashicorp/design-system/pull/3366/files#diff-074e93daf2b887754190700afcd3a23549777642058dbac67048a50b832417afR16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would convert the remaining modifier and helper tests to gts or typescript. This PR has to be merged in after: #3326
🔗 External links
Jira ticket: HDS-5581
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.