-
Notifications
You must be signed in to change notification settings - Fork 51
Showcase: convert integration tests to gts/gjs #3326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
showcase/tests/integration/components/hds/accordion/index-test.gts
Outdated
Show resolved
Hide resolved
showcase/tests/integration/components/hds/accordion/index-test.gts
Outdated
Show resolved
Hide resolved
4ecc8f2 to
0837240
Compare
0837240 to
6055c04
Compare
6055c04 to
db90285
Compare
db90285 to
55ee921
Compare
55ee921 to
b2fcd3e
Compare
30be8eb to
179bcf0
Compare
| <HdsPaginationNavNumber | ||
| @page={{1}} | ||
| @onClick={{NOOP}} | ||
| @isSelected={{false}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the onClick and isSelected arguments be updated in the component definition to set a default or something so they won't be left missing like they were previously? (Since this now uses typescript and the arguments aren't defined as optional in the component definition, I guess that's already the case though?)
showcase/tests/integration/components/hds/popover-primitive/index-test.gts
Show resolved
Hide resolved
| .querySelector('.hds-disclosure-primitive__content') | ||
| .getAttribute('id'), | ||
| toggleButton?.getAttribute('aria-controls'), | ||
| content?.getAttribute('id'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Syntax is clearer
showcase/tests/integration/components/hds/rich-tooltip/bubble-test.gts
Outdated
Show resolved
Hide resolved
showcase/tests/integration/components/hds/rich-tooltip/bubble-test.gts
Outdated
Show resolved
Hide resolved
showcase/tests/integration/components/hds/rich-tooltip/bubble-test.gts
Outdated
Show resolved
Hide resolved
…test.gts Co-authored-by: Kristin Bradley <[email protected]>
…test.gts Co-authored-by: Kristin Bradley <[email protected]>
showcase/tests/integration/components/hds/rich-tooltip/bubble-test.gts
Outdated
Show resolved
Hide resolved
showcase/tests/integration/components/hds/stepper/step-indicator-test.gts
Show resolved
Hide resolved
KristinLBradley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a number of comments and a couple suggested changes for typos/clarification
KristinLBradley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
📌 Summary
If merged, this PR updates the component integration tests to use the
gtsformat.The commits in the PR are organized as follows:
gjs(there were a couple that couldn't be automatically converted)gjstogtsThe changes include:
hbswrapper around what the test renders, instead using<template>tagsTrackedObject/Arrayinstead ofthis.set()beforeEachfor setting global values and instead defining things within the individual test contextadvanced-table/index(this was just to make the file more understandable)UPDATE
To make the ember matrix tests pass, I had to update the
gjstest files to not usethis.setanymore.REVIEWERS
Using the order of commits, you can click the link for the commit of the first component you are supposed to look at and then step through
If your section is looking good - please throw an approval on this PR, otherwise leave a comment.
🔗 External links
Jira ticket: HDS-XXX
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.