-
Notifications
You must be signed in to change notification settings - Fork 51
[05] [Project Solar / Phase 1 / Showcase] Scaffolding of the showcase pages for the carbonization of the HDS components #3241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
didoo
wants to merge
47
commits into
project-solar/phase-1/HDS-5242_showcase/add-themes-support
Choose a base branch
from
project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding
base: project-solar/phase-1/HDS-5242_showcase/add-themes-support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,145
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
19234bc to
cd4e9ef
Compare
cd4e9ef to
a0b23a9
Compare
519a6a6 to
3863dfa
Compare
a0b23a9 to
403ac45
Compare
403ac45 to
9376a33
Compare
9376a33 to
8bc9cc9
Compare
8bc9cc9 to
f8e77f1
Compare
f8e77f1 to
68248e2
Compare
…parison of typographic styles
…onTokenPreviewColor` to show actual color values in preview item
… “carbonized” page (and restore its previous state when returning to non-carbonized pages)
…t rendered as “classic” HDS
215bbb2 to
d867ad5
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 42 out of 43 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
showcase/app/components/page-components/badge/sub-sections/content.gts:1
- Import order was changed but
ShwFlexis still imported correctly afterShwTextH2. The original diff shows swapped import order which should not cause issues, but ensure this was an intentional reordering for consistency with project conventions.
/**
showcase/app/components/shw/carbonization/token-preview/color.gts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR is the initial scaffolding of the showcase pages that will be used for the dry-run migrations (and subsequent actual migration) of the HDS components (as in theming/re-skinning).
This PR is based on top of #3240.
🛠️ Detailed description
In this PR I have:
<ShwCarbonizationComparisonGrid>component, used to showcase an HDS component with different themes applied (HDSdefault+ the four Carbon modescds-g0/cds-g10/cds-g90/cds-g100) next to the equivalent Carbon web components for that specific variant/state.Shwcomponent for the preview of colors (<ShwCarbonizationTokenPreviewColor>) and typographic styles (<ShwCarbonizationStylePreviewTypography>)showcase/app/index.htmlfile to include<script>tags used to include the Carbon web components<script>tags used to import the IBM Plex font<style>tag used to hide the not-yet-loaded web components🔎 How to review
Check the different carbonized pages and how they've been implemented (also their organization as single file
.gtscomponents):Note: don't focus on the actual visual style of the "carbonized" component: the proper design tokens and
$modeswill be implemented the #3332Review the implementation of the
<ShwCarbonizationComparisonGrid>component, and see if the API is clear to you; look also at how it's used across the "carbonized" showcase pagesReview how the Carbon Web components are instantiated in the code, and how Carbon theming is applied to them
Note: at the moment there's an open conversation about how to use the
cds-iconweb component in an Ember app, that has not been resolved yet, so we're using theHdsIconcomponent instead👉 👉 👉 Previews:
🛠️ How to test
Note
At the moment the HDS component look the same for the different themes, because the underlying design tokens are all the same; once we start the dry-run migrations (in the follow-up PR) they will start to look more and more like the equivalent Carbon web components shown below
Open the different "carbonized" pages and see how the HDS components are rendered, and how the Carbon Web components are rendered
🔗 External links
Main Jira task:
Related Jira tasks
👀 Component checklist
A changelog entry was added via Changesets if needed (see templates here)💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.