Skip to content

Conversation

@zamoore
Copy link
Contributor

@zamoore zamoore commented Sep 18, 2025

πŸ“Œ Summary

If merged, this PR drops 3.28 from the ember-try test configuration.

πŸ› οΈ Detailed description

We are removing support for Ember 3.x.x in version 5.0.0 of Helios.

πŸ”— External links

Jira ticket: HDS-4946


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

πŸ“‹ PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Sep 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 1, 2025 2:21am
hds-website Ready Ready Preview Oct 1, 2025 2:21am

@dchyun
Copy link
Contributor

dchyun commented Sep 18, 2025

Looks good to me! Just one other place to update. We should remove the 3.28 test from the github action.

.github/workflows/ci-components.yml

strategy:
  fail-fast: false
  matrix:
    try-scenario:
      - ember-lts-3.28

Also, found another 3.28 related task not related to this. Just calling it out for visibility. There is this comment in the hds-link-to-query helper.

// this is a workaround for https://github.com/emberjs/ember.js/issues/19693
// don't remove until we drop support for ember 3.27 and 3.28

@zamoore
Copy link
Contributor Author

zamoore commented Sep 18, 2025

Looks good to me! Just one other place to update. We should remove the 3.28 test from the github action.

.github/workflows/ci-components.yml

strategy:
  fail-fast: false
  matrix:
    try-scenario:
      - ember-lts-3.28

Also, found another 3.28 related task not related to this. Just calling it out for visibility. There is this comment in the hds-link-to-query helper.

// this is a workaround for https://github.com/emberjs/ember.js/issues/19693
// don't remove until we drop support for ember 3.27 and 3.28

Hey Dylan, it is removed there. Thanks for the review!

@didoo
Copy link
Contributor

didoo commented Sep 19, 2025

Hey Dylan, it is removed there.

@zamoore removed where? will it be done in a separate PR?

@dchyun
Copy link
Contributor

dchyun commented Sep 19, 2025

Hey Dylan, it is removed there.

@zamoore removed where? will it be done in a separate PR?

@didoo From what I can see in the diff it looks like it was removed in this PR
Screenshot 2025-09-19 at 9 17 36β€―AM

@didoo
Copy link
Contributor

didoo commented Sep 19, 2025

@didoo From what I can see in the diff it looks like it was removed in this PR

Ahhh no I meant the hds-link-to-query helper!

@zamoore
Copy link
Contributor Author

zamoore commented Sep 19, 2025

@didoo From what I can see in the diff it looks like it was removed in this PR

Ahhh no I meant the hds-link-to-query helper!

My bad. I was referring to the github action. We can address the comment you found after the 5.0.0 release or as part of it. Going to omit it from this PR.

@didoo
Copy link
Contributor

didoo commented Sep 19, 2025

We can address the comment you found after the 5.0.0 release or as part of it.

@zamoore If possible, better to address it in this release (so we can revert it if we test and find it doesn't work). Not sure if there is a ticket associated, in case you can create a new one.

Going to omit it from this PR.

πŸ‘

@zamoore zamoore force-pushed the main-5.0.0 branch 2 times, most recently from 7c0bc36 to 81a4cea Compare September 19, 2025 19:19
@alex-ju
Copy link
Member

alex-ju commented Oct 1, 2025

Created HDS-5534 to review the need for hds-link-to-query.ts helper.

@zamoore zamoore merged commit 8b609a2 into main-5.0.0 Oct 1, 2025
15 checks passed
@zamoore zamoore deleted the zamoore/hds-4946/update-ember-try-matrix branch October 1, 2025 12:49
@zamoore zamoore mentioned this pull request Oct 1, 2025
5 tasks
zamoore added a commit that referenced this pull request Oct 1, 2025
zamoore added a commit that referenced this pull request Oct 2, 2025
zamoore added a commit that referenced this pull request Oct 3, 2025
zamoore added a commit that referenced this pull request Oct 3, 2025
zamoore added a commit that referenced this pull request Oct 6, 2025
zamoore added a commit that referenced this pull request Oct 7, 2025
zamoore added a commit that referenced this pull request Oct 7, 2025
zamoore added a commit that referenced this pull request Oct 8, 2025
zamoore added a commit that referenced this pull request Oct 9, 2025
zamoore added a commit that referenced this pull request Oct 10, 2025
zamoore added a commit that referenced this pull request Oct 10, 2025
zamoore added a commit that referenced this pull request Oct 13, 2025
zamoore added a commit that referenced this pull request Oct 14, 2025
zamoore added a commit that referenced this pull request Oct 27, 2025
zamoore added a commit that referenced this pull request Oct 27, 2025
zamoore added a commit that referenced this pull request Oct 28, 2025
zamoore added a commit that referenced this pull request Oct 31, 2025
zamoore added a commit that referenced this pull request Nov 3, 2025
aklkv pushed a commit that referenced this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants