Skip to content

feat: expand guard broker client#168

Merged
kantorcodes merged 3 commits into
mainfrom
guard-market-fit-sdk
Apr 12, 2026
Merged

feat: expand guard broker client#168
kantorcodes merged 3 commits into
mainfrom
guard-market-fit-sdk

Conversation

@kantorcodes

Copy link
Copy Markdown
Member

Updates Guard client support for the current phase.

Verification

  • pnpm exec jest --config jest.config.json --runTestsByPath tests/services/registry-broker-guard-client.test.ts --coverage=false
  • pnpm run typecheck
  • pnpm run lint
  • pnpm run build

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly expands the RegistryBrokerClient by implementing a wide range of 'Guard' service features, including artifact ABOM exports, pain signal management, preflight verdicts, and team policy pack updates. The changes include new API client methods, Zod schemas for response validation, and comprehensive test coverage. Feedback focuses on a logic bug in the limit parameter handling for the guard feed, Node.js compatibility for URL parameter checks, and a recommendation to use jsonValueSchema instead of z.unknown() in the security breakdown schema to preserve type information for consumers.

Comment thread src/services/registry-broker/client/guard.ts Outdated
Comment thread src/services/registry-broker/schemas.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2a2584e52

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/services/registry-broker/schemas.ts Outdated
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b6fa93bde

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/services/registry-broker/client/guard.ts
Comment thread src/services/registry-broker/schemas.ts
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
@kilo-code-bot

kilo-code-bot Bot commented Apr 12, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No New Issues Found | Recommendation: Merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 0

The PR adds new Guard client methods following established patterns. Code is well-typed with Zod schemas, includes proper input validation (e.g., artifactId.trim() checks), and passes linting. TypeScript errors are pre-existing in unrelated test files.

Files Reviewed (4 files)
  • src/services/registry-broker/client/guard.ts - New API methods
  • src/services/registry-broker/client/base-client.ts - Client class additions
  • src/services/registry-broker/schemas.ts - Zod schema definitions
  • __tests__/services/registry-broker-guard-client.test.ts - Test coverage

Reviewed by minimax-m2.5-20260211 · 86,379 tokens

@kantorcodes kantorcodes merged commit 24db577 into main Apr 12, 2026
11 checks passed
@kantorcodes kantorcodes deleted the guard-market-fit-sdk branch April 12, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant