feat: expand guard broker client#168
Conversation
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request significantly expands the RegistryBrokerClient by implementing a wide range of 'Guard' service features, including artifact ABOM exports, pain signal management, preflight verdicts, and team policy pack updates. The changes include new API client methods, Zod schemas for response validation, and comprehensive test coverage. Feedback focuses on a logic bug in the limit parameter handling for the guard feed, Node.js compatibility for URL parameter checks, and a recommendation to use jsonValueSchema instead of z.unknown() in the security breakdown schema to preserve type information for consumers.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2a2584e52
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b6fa93bde
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Code Review SummaryStatus: No New Issues Found | Recommendation: Merge Overview
The PR adds new Guard client methods following established patterns. Code is well-typed with Zod schemas, includes proper input validation (e.g., Files Reviewed (4 files)
Reviewed by minimax-m2.5-20260211 · 86,379 tokens |
Updates Guard client support for the current phase.
Verification