Skip to content

feat: update registry broker client surface#164

Merged
kantorcodes merged 5 commits into
mainfrom
feat/guard-rb-client
Apr 10, 2026
Merged

feat: update registry broker client surface#164
kantorcodes merged 5 commits into
mainfrom
feat/guard-rb-client

Conversation

@kantorcodes

Copy link
Copy Markdown
Member

Summary

  • add a few registry broker client additions
  • cover the new paths with tests
  • tighten one runtime import edge case

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
@kilo-code-bot

kilo-code-bot Bot commented Apr 10, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (10 files)
  • __tests__/services/registry-broker-credits-client.test.ts - Tests for credits endpoints
  • __tests__/services/registry-broker-guard-client.test.ts - Tests for guard endpoints
  • __tests__/services/registry-broker-skills-client.test.ts - Tests for skill growth endpoints
  • src/services/registry-broker/client/base-client.ts - New client methods
  • src/services/registry-broker/client/credits.ts - Credits module implementation
  • src/services/registry-broker/client/guard.ts - Guard module implementation
  • src/services/registry-broker/client/skills.ts - Skills module implementation
  • src/services/registry-broker/schemas.ts - Schema definitions
  • src/services/registry-broker/types.ts - Type definitions
  • src/utils/dynamic-import.ts - Dynamic import utilities

Summary: This PR adds new client methods for credits, guard, and skill growth endpoints to the Registry Broker client. The implementation includes:

  • Credits: getCreditsBalance, getCreditProviders, createHbarPurchaseIntent
  • Guard: getGuardSession, getGuardEntitlements, getGuardBillingBalance, getGuardTrustByHash, resolveGuardTrust, getGuardRevocations, syncGuardReceipts
  • Skills: getSkillStatus, getSkillStatusByRepo, getSkillConversionSignalsByRepo, uploadSkillPreviewFromGithubOidc, getSkillPreview, getSkillPreviewByRepo, getSkillPreviewById, getSkillInstall, recordSkillInstallCopy, quoteSkillPublishPreview

Also includes security improvement to createEphemeralKeyPair using Web Crypto API fallback, and Node.js getBuiltinModule support in dynamic-import utilities.

All new functionality appears well-tested and follows existing patterns in the codebase.


Reviewed by minimax-m2.5-20260211 · 912,969 tokens

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request expands the RegistryBrokerClient with new functionalities for credits, guard services, and skill management, including API methods and corresponding Zod schemas. It also refactors secure random byte generation and internal module loading. Review feedback suggests refactoring repeated validation logic into a shared helper, enhancing type safety in schemas by replacing unknown types with specific definitions, and moving internal helper declarations outside of functions for better code organization.

Comment thread src/services/registry-broker/client/skills.ts Outdated
Comment thread src/services/registry-broker/schemas.ts
Comment thread src/utils/dynamic-import.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9d540a9f0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/utils/dynamic-import.ts Outdated
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
@kantorcodes kantorcodes merged commit 466b877 into main Apr 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant