feat: update registry broker client surface#164
Conversation
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (10 files)
Summary: This PR adds new client methods for credits, guard, and skill growth endpoints to the Registry Broker client. The implementation includes:
Also includes security improvement to All new functionality appears well-tested and follows existing patterns in the codebase. Reviewed by minimax-m2.5-20260211 · 912,969 tokens |
There was a problem hiding this comment.
Code Review
This pull request expands the RegistryBrokerClient with new functionalities for credits, guard services, and skill management, including API methods and corresponding Zod schemas. It also refactors secure random byte generation and internal module loading. Review feedback suggests refactoring repeated validation logic into a shared helper, enhancing type safety in schemas by replacing unknown types with specific definitions, and moving internal helper declarations outside of functions for better code organization.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9d540a9f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Summary