Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors moved to variables in SCSS #3026

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LorincJuraj
Copy link

This will simplify theming process and integration into existing project.

sass/chosen.scss Outdated Show resolved Hide resolved
sass/chosen.scss Outdated Show resolved Hide resolved
@tjschuck
Copy link
Member

tjschuck commented Oct 5, 2018

/cc @mlettini

$chosen-border-color: #aaa;
$chosen-group-name-color: #999;
$chosen-highlighted-color: #3875d7;
$chosen-highlighted-second-color: #2a62bc;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of using two different colors here to represent a gradient. You have gradients in variables below, so why not do the same here. Also, we could clarify that these are background colors. I'd recommend:

$chosen-highlighted-bg-color: #3875d7;
$chosen-highlighted-bg-gradient: linear-gradient(#3875d7 20%, #2a62bc 90%);

$chosen-bg-color: #fff;
$chosen-box-shadow-color: #000;
$chosen-border-color: #aaa;
$chosen-group-name-color: #999;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of colors here. I like what you started with clarifying whether a color is background or border or box-shadow or whatever. I think we should keep that going with text colors too, so I'd recommend this be $chosen-group-name-text-color.


$chosen-search-choice-bg-color: #eee;
$chosen-search-choice-disabled-bg-color: #e4e4e4;
$chosen-search-choice-color: #333;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same "text" comment here: $chosen-search-choice-text-color

$chosen-search-choice-bg-color: #eee;
$chosen-search-choice-disabled-bg-color: #e4e4e4;
$chosen-search-choice-color: #333;
$chosen-search-choice-bg: linear-gradient(#f4f4f4 20%, #f0f0f0 50%, #e8e8e8 52%, #eee 100%);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend us using the word "gradient" here, and in terms of line ordering, this should be bundled with $chosen-search-choice-bg-color, since those two are next to each other in the css too.

$chosen-search-choice-bg-color: #eee;
$chosen-search-choice-bg-gradient: linear-gradient(#f4f4f4 20%, #f0f0f0 50%, #e8e8e8 52%, #eee 100%);

$chosen-search-choice-disabled-bg-color: #e4e4e4;
$chosen-search-choice-color: #333;
$chosen-search-choice-bg: linear-gradient(#f4f4f4 20%, #f0f0f0 50%, #e8e8e8 52%, #eee 100%);
$chosen-search-choice-disabled-color: #666;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same "text" comment here: $chosen-search-choice-disabled-text-color

$chosen-search-choice-disabled-color: #666;
$chosen-search-choice-focus-bg-color: $chosen-search-choice-disabled-color;
$chosen-search-choice-disabled-border-color: #ccc;
$chosen-no-results-bg: #f4f4f4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other variable names, this should be $chosen-no-results-bg-color

$chosen-search-choice-disabled-border-color: #ccc;
$chosen-no-results-bg: #f4f4f4;

$chosen-color: #222;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same "text" comment here: $chosen-text-color

$chosen-no-results-bg: #f4f4f4;

$chosen-color: #222;
$chosen-border-color: #5897fb;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first actual issue I see in the code. $chosen-border-color is already being defined above. Looking at the CSS, #5897fb is only used when active/focused. So I think this should be $chosen-active-border-color. I see some other active/focused-specific variables, and I think those variables should be grouped together, and have consistent naming.


$chosen-color: #222;
$chosen-border-color: #5897fb;
$chosen-single-color: #444;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same "text" comment here: $chosen-single-text-color

$chosen-container-no-results-color: #777;
$chosen-choices-color: #999;
$chosen-choices-bg: linear-gradient($chosen-search-choice-bg-color 1%, $chosen-bg-color 15%);
$chosen-drop-result-selected: $chosen-search-choice-disabled-border-color;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how I feel about using a variable inside the definition of another variable. Normally I'd be all for it, but in this case (and a few other cases I see in this file), the variables are completely unrelated. For instance, $chosen-drop-result-selected has absolutely nothing to do with $chosen-search-choice-disabled-border-color (other than being a similar hex color), and by making the former defined by the latter, the code is making the two seem related in some way. I'll let another dev make a call on that (cc @stof)

Copy link
Contributor

@mlettini mlettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this idea of moving colors into variables to prepare for better theming. Nice work @LorincJuraj.

I didn't actually finish leaving all the comments I had, because I realized 1. I was adding those comments individually instead of all at once with a review, which can be annoying for notifications (sorry didn't mean to do that), and 2. I was repeating myself regarding naming conventions. Most of my comments are either about naming, or which variables we group together. So my feedback can be boiled down to essentially:

  • Let's keep the naming consistent and visual. If the color is for a background color, let's use -bg-color:, for background gradient -bg-gradient, for text color -text-color, etc etc.
  • Let's keep the order and grouping of variables consistent with how they are used in the CSS below. So all -bg-color:s and -bg-gradients: should be next to each other, all active/focus colors grouped together, disabled, single, multi, etc etc.

So take that into account with all the variables, including the lines I didn't comment on. ✌️

@LorincJuraj
Copy link
Author

@mlettini Thanks for comments. You are right I should be more consistent with the naming. I was doing this quickly when I was testing Chosen on one of my projects and I needed quick working solution. If you have the variables renamed feel free to do the commit, because I am not sure, when will I get a chance to do it myself, because i have some deadlines which are getting pretty tight, so I have to focus on them right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants