Support hidden property on option and optgroup elements. #2903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the
hidden
attribute on options and optgroups.It probably has other applications, and I don't see any reason not to support it anyway - but my primary motivation is to make it easier to provide a graceful fallback on devices that Chosen does not support.
Placeholders in native
select
s can be more or less correctly "simulated" in all modern browsers by setting theselected
,disabled
andhidden
props on the first option: StackOverflow answerWithout this patch Chosen still shows the option though.
If we simply read and respect the
hidden
attribute, it all works perfectly.So some sort of placeholders can be shown on all devices, even those Chosen does not support using markup like this:
I'm fairly certain there are no negative side effects of supporting this attribute.
package.json
.