Code

Tiny tweaks to form processing#3673

Code

Merged

rebeccacremona merged 13 commits intoharvard-lil:developharvard-lil/perma:developfrom rebeccacremona:quick-tweaksrebeccacremona/perma:quick-tweaksCopy head branch name to clipboardDec 6, 2024

+48-63

Commits

Commits on Dec 4, 2024

• Remove redundant variables.

  rebeccacremona

  committed
  217ab9a

  Copy full SHA for 217ab9a

• Store raw email in user_data; use lowercased version as key.

  rebeccacremona

  committed
  669f56a

  Copy full SHA for 669f56a

• Store collection of updated users in one spot.

  rebeccacremona

  committed
  4380427

  Copy full SHA for 4380427

• Handle existing users in a single, uninterrupted block of logic.

  rebeccacremona

  committed
  08b7e30

  Copy full SHA for 08b7e30

• Create all new affilation objects in one batch, instead of splittin by new/existing users.

  rebeccacremona

  committed
  b200386

  Copy full SHA for b200386

• Perform check even if commit is False.

  rebeccacremona

  committed
  d83eebd

  Copy full SHA for d83eebd

• Move commit check to save operation.

  rebeccacremona

  committed
  e4a68d7

  Copy full SHA for e4a68d7

• Remove redundant existence check.

  rebeccacremona

  committed
  0eb74d0

  Copy full SHA for 0eb74d0

• Use select_related to reduce calls to the database from n to 1.

  rebeccacremona

  committed
  6925139

  Copy full SHA for 6925139

• Whitespace, comment.

  rebeccacremona

  committed
  92e032f

  Copy full SHA for 92e032f

Commits on Dec 5, 2024

• Update perma_web/perma/forms.py

  Show description for d6479f5
  

  rebeccacremona

  and

  cmsetzer

  authored
  d6479f5

  Copy full SHA for d6479f5

• Update perma_web/perma/forms.py

  Show description for 09c88c8
  

  rebeccacremona

  and

  cmsetzer

  authored
  09c88c8

  Copy full SHA for 09c88c8

• Calling set on dict implicitly makes a set of the keys.

  Show description for 5478649
  

  rebeccacremona

  and

  cmsetzer

  authored
  5478649

  Copy full SHA for 5478649