Upgrade from Django 3.2 to 4.2 #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccacremona
requested review from
bensteinberg
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Django 3.2 (LTS) will end in April. This PR upgrades us to the next LTS version, 4.2, which will be supported until April 2026.
Default storage and staticfile storage is configured significantly differently in 4.2: instead of a lot of stand-alone settings, everything is configured via key-value pairs in a big dict. So, the settings for stage and prod will have to be reconfigured before deployment.
I had to update a number of supporting packages for compatibility and to resolve deprecation warnings.
The only remaining warnings are the one we already had, from warcprox, and one that I think happens merely because we are patching
django.utils.timezone: simply mocking it is seems to be enough to trigger the deprecation warning. I think that will go away by itself during the next upgrade.