Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [CDS-99267]: Update toggle pill color for dark and light mode #1395

Merged
merged 3 commits into from
Oct 17, 2024
Merged

fix: [CDS-99267]: Update toggle pill color for dark and light mode #1395

merged 3 commits into from
Oct 17, 2024

Conversation

sarthak-setia
Copy link
Contributor

@sarthak-setia sarthak-setia commented Sep 12, 2024 •
edited
Loading

You can use the following comments to re-trigger PR Checks

  • Jest: retrigger jest
  • Prettier: retrigger prettier
  • Type Check: retrigger typecheck
  • ESLint: retrigger eslint
  • StyleLint: retrigger stylelint
  • Build: retrigger build
  • Title Check: retrigger titlecheck
  • ImageSnapshot retrigger ImageSnapshot
Screenshot 2024-10-01 at 12 41 57 PM Screenshot 2024-10-01 at 12 42 21 PM Screenshot 2024-10-01 at 12 42 03 PM Screenshot 2024-10-01 at 12 42 17 PM

@sarthak-setia sarthak-setia self-assigned this Sep 12, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bot2-harness
Copy link

Image snapshots failed please check https://console.cloud.google.com/storage/browser/ui-team-bucket/uicore-2656

@bot2-harness
Copy link

Image snapshots failed please check https://console.cloud.google.com/storage/browser/ui-team-bucket/uicore-2667

MondalSayantan
MondalSayantan reviewed Sep 17, 2024
View reviewed changes
packages/uicore/src/components/Toggle/Toggle.css Outdated
@@ -9,8 +9,8 @@
--toggle-background-color: var(--white);
--toggle-border-color: #c7c9d9; /* grey-200 too light and grey-250/300 too dark */
--toggle-pill-size: var(--spacing-4);
--toggle-pill-color: var(--white);
--toggle-pill-shadow: 0 1px 2px rgba(40, 41, 61, 0.2), 0 2px 4px rgba(96, 97, 112, 0.2);
--toggle-pill-color: #c7c9d9; /* Needs to be consistent in light and dark mode */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a variable for this color: --toggle-border-color. Let's use that

@MondalSayantan
Copy link
Member

Please add screenshots for light and dark mode

@bot2-harness
Copy link

Image snapshots failed please check https://console.cloud.google.com/storage/browser/ui-team-bucket/uicore-2674

@MondalSayantan
Copy link
Member

Please bump the uicore package

@bot2-harness
Copy link

Image snapshots failed please check https://console.cloud.google.com/storage/browser/ui-team-bucket/uicore-2701

@bot2-harness
Copy link

Image snapshots failed please check https://console.cloud.google.com/storage/browser/ui-team-bucket/uicore-2702

@bot2-harness
Copy link

Image snapshots failed please check https://console.cloud.google.com/storage/browser/ui-team-bucket/uicore-2723

@sarthak-setia sarthak-setia merged commit 298ea80 into main Oct 17, 2024
7 of 8 checks passed
@sarthak-setia sarthak-setia deleted the CDS-99267 branch October 17, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MondalSayantan MondalSayantan MondalSayantan approved these changes

@avinashmadhwani02 avinashmadhwani02 avinashmadhwani02 approved these changes

Assignees

@sarthak-setia sarthak-setia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sarthak-setia @CLAassistant @bot2-harness @MondalSayantan @avinashmadhwani02