Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hdh306 migrate gitness docs #8045

Merged
merged 11 commits into from
Sep 23, 2024

Conversation

dewan-ahmed
Copy link
Collaborator

@dewan-ahmed dewan-ahmed commented Sep 18, 2024

Description

Please ensure we review the following:

  • src/components files are properly defined for Harness Open Source.
  • If any CSS change is needed for this work.
  • All required images/logos/icons for Harness Open Source are added.
  • All the internal links work after the migration. For example, any /docs link from Gitness Docs will be /docs/open-source after this migration.
  • IMPORTANT: We're not breaking anything during this migration.

PR lifecycle

We aim to merge PRs within one week or less, but delays happen sometimes.

If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

@dewan-ahmed dewan-ahmed added the DO NOT MERGE PR is not ready to be merged. label Sep 18, 2024
@dewan-ahmed dewan-ahmed self-assigned this Sep 18, 2024
@dewan-ahmed
Copy link
Collaborator Author

dewan-ahmed commented Sep 18, 2024

Known Issue(s):

  • Since there are no Release Notes or Knowledge Base for Harness Open Source, we'll replace these with something else, like "Getting Started" and "Tutorials". We'll also need a new landing page for Harness Open Source.

Screenshot 2024-09-18 at 1 05 36 PM

@SushrutHarness
Copy link
Collaborator

I've created a PR into this one to fix the broken links: https://github.com/dewan-ahmed/developer-hub/pull/1

Plus I just merged a commit fixing known issue 1 above.

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66eb9c6d13983605ab375517--harness-developer.netlify.app

@rohanmaharjan100
Copy link
Collaborator

@dewan-ahmed Can we temporarily use the Gitness logo on the sidebar until the new module icon for Open Source is ready?
image
Logo on side bar can be added as :

<div className={styles.topSection}>
<div className={styles.spaceBetween}>
<div className={styles.moduleTitle}>
<img src={`${baseUrl}img/icon_code.svg`} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Code Repository icon here ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used Code Repo as template. Some of the lines need to be updated to reference Harness Open SOurce.

@dewan-ahmed
Copy link
Collaborator Author

@dewan-ahmed Can we temporarily use the Gitness logo on the sidebar until the new module icon for Open Source is ready? image Logo on side bar can be added as :

hoss_logo_reverse
icon_opensource
@rohanmaharjan100 we have the logos

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66eda07af20b6d1a08809a90--harness-developer.netlify.app

@dewan-ahmed
Copy link
Collaborator Author

Release Notes link for Harness Open Source can point to https://github.com/harness/gitness/releases @rohanmaharjan100

@SushrutHarness
Copy link
Collaborator

Update Whats Support to API Docs reference link

@dewan-ahmed
Copy link
Collaborator Author

@rohanmaharjan100 for the icon, we can use Harness icon as Harness Open Source icon.

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66f12942da8e37b832077686--harness-developer.netlify.app

@dewan-ahmed
Copy link
Collaborator Author

@SushrutHarness dc00264 renames applicable 'Gitness' texts with 'Harness Open Source'. There are still many references like the environment variables which we cannot change until those are updated within product first. This commit also touches some CD pages. Please review 👀 Thanks.

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66f192b3756056409c13f482--harness-developer.netlify.app

Copy link
Collaborator

@pratmit pratmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dewan-ahmed dewan-ahmed removed the DO NOT MERGE PR is not ready to be merged. label Sep 23, 2024
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66f19ad71b621d525fa7c919--harness-developer.netlify.app

@dewan-ahmed
Copy link
Collaborator Author

I aim to merge this PR around 11 AM PST. Let's not add anymore commits unless something major is broken. We can continue updating post-merge.

Copy link
Collaborator

@SushrutHarness SushrutHarness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dewan-ahmed dewan-ahmed merged commit 27dbdfa into harness:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants