Split VaultRegistry from OneBtc For the Contract Size Issue#85
Open
Split VaultRegistry from OneBtc For the Contract Size Issue#85
Conversation
gupadhyaya
reviewed
Jan 27, 2022
| IExchangeRateOracle oracle; | ||
|
|
||
| function initialize(IRelay _relay, IExchangeRateOracle _oracle) external initializer { | ||
| function initialize(IRelay _relay, IExchangeRateOracle _oracle, IVaultRegistry _vaultRegistry) external initializer { |
Contributor
There was a problem hiding this comment.
will this create an issue for contract upgrade? as upgrade don't work with new initializer? can you double check?
Contributor
Author
There was a problem hiding this comment.
Added functions to update the contract addresses in initialize() functions.
|
VaultRegistry and Collateral as separate contract makes a lot of sense. This will lower the contract size on OneBTC significantly! The branch is quite out of date, maybe it's less risky branching off from main now, and carefully copy over? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.