vault liquidation for under collateralization #91#100
Open
hashmesan wants to merge 5 commits intoharmony-one:mainfrom
Open
vault liquidation for under collateralization #91#100hashmesan wants to merge 5 commits intoharmony-one:mainfrom
hashmesan wants to merge 5 commits intoharmony-one:mainfrom
Conversation
added 2 commits
April 19, 2022 11:20
… keep size down, renamed errors to reduce contract size. harmony-one#91
hashmesan
commented
Apr 27, 2022
|
|
||
| // require(oldVault.btcPublicKeyX != 0, "Vault does not exist"); | ||
| // require(newVault.btcPublicKeyX != 0, "Vault does not exist"); | ||
| // require(oldVault.btcPublicKeyX != 0, "VDNE"); |
Contributor
|
@hashmesan could you resolve the conflict? also, the |
Author
|
I think i forgot to check in the 2.5% penalty after i switched branch. |
added 3 commits
May 2, 2022 12:30
…perly handle used/and balance change.; test case validate transfer of collateral and issues
…ealthy collateral levels close to contract size issue.
Author
|
Merged with main. |
Contributor
|
@hashmesan can you reiterate the design here? i thought the vault that has gone under collateral will be penalized 2.5%. however the code seem to indicate that 2.5% is paid to the reporter and the vault is fully liquidated? could you clarify? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.