refactor(hm-common): fs::write_create_all - #170
Merged
Merged
Conversation
Rework the hm-common fs helper introduced in 09dd3d6. Instead of a bare create_dir_all returning a typed FsError, provide write_create_all, which joins std::fs::create_dir_all(parent) and std::fs::write into one call and returns io::Error directly — no bespoke error type. Migrate the three write sites (hm init x2, hm run) to it, each collapsing a create-dir + write pair (and, for run, an if-let parent block) into a single call. The two mkdir-only sites (hm-vm registry, hm-dsl-engine bundled_sources) don't write a file, so they revert to std::fs::create_dir_all and drop their now-unused hm-common dep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.