This repository was archived by the owner on Mar 31, 2025. It is now read-only.
Certain method overwriting and symbols moved the NamedTrajectories#21
Open
jack-champagne wants to merge 2 commits into
Open
Certain method overwriting and symbols moved the NamedTrajectories#21jack-champagne wants to merge 2 commits into
jack-champagne wants to merge 2 commits into
Conversation
Member
Author
|
These two minute turn around times are so nice. I feel blessed |
jack-champagne
commented
Mar 10, 2025
Member
Author
There was a problem hiding this comment.
This file exposes where we have multiple definitions of the same function. Where did we land on where these should live?
Member
There was a problem hiding this comment.
I think the current vision is that we want to export less. So, the losses that live in PQO are good to be exported, but QC losses are about to get refactored due to DirectTrajOpt (so I would rather they don't get exported). Is this the conflict you're referencing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*_suffixfunctionsBase.endswith(symbol, ...)