T0: extend Intonato hardware-backend generics instead of shadowing#3
Merged
Merged
Conversation
Paired with Intonato's AbstractHardwareBackend realization (T0.4, spec spec-20260708-140522, armonissima#33). Intonato now declares upload_pulse! / trigger! / readout / sample_rate as exported generic functions. Add an explicit `import Intonato: upload_pulse!, trigger!, readout, sample_rate` so QickBackend's methods (backend.jl) EXTEND the shared generics rather than define local same-named functions that would collide with the newly-exported names under `using Intonato`. No other change: backend.jl / experiment.jl method definitions and the qualified `IntonatoQICK.upload_pulse!` test calls resolve to the imported generics unchanged. Verified end-to-end: with the modified Intonato dev'd in, IntonatoQICK precompiles and `IntonatoQICK.upload_pulse! === Intonato.upload_pulse!` with the QickBackend method registered on Intonato's generic (extend, not shadow). Requires Intonato ≥ the release carrying these exports; compat bump lands with that release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
aarontrowbridge
added a commit
that referenced
this pull request
Jul 11, 2026
Registered Intonato 0.2.0 predates the upload_pulse!/trigger!/readout/sample_rate generics that #3 imports, so main is red against the registry. Intonato 0.3.0 is registering now (harmoniqs/Intonato.jl@822b017); this admits it. Drops 0.1 from compat — the T0 seam has required 0.2-era API since #3. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with Intonato — realize AbstractHardwareBackend. T0 from the API-ergonomics program (spec armonissima#33).
What
Intonato now declares
upload_pulse!/trigger!/readout/sample_rateas exported generic functions. Add an explicitimport Intonato: upload_pulse!, trigger!, readout, sample_ratesoQickBackend's methods (backend.jl) extend the shared generics rather than define local same-named functions — which would collide with the newly-exported names underusing Intonato.One line of change;
backend.jl/experiment.jlmethod bodies and the qualifiedIntonatoQICK.upload_pulse!test calls resolve to the imported generics unchanged.Verified end-to-end
With the paired Intonato branch dev'd in, IntonatoQICK precompiles and:
IntonatoQICK.upload_pulse! === Intonato.upload_pulse!→ true (extend, not shadow)QickBackendmethod is registered onIntonato's genericMerge coordination
Merge the Intonato PR first; this one requires Intonato ≥ the release carrying the exports (compat bump lands with that release).
🤖 Generated with Claude Code