ci(benchmarks): publish dashboards on v* tags (fix never-publishing gate)#102
Merged
Conversation
The three benchmark workflows trigger only on `push: tags:['v*']` + pull_request + workflow_dispatch (never on push to main), but save-data-file / auto-push were gated to `github.ref == 'refs/heads/main'`. Those conditions are mutually exclusive, so the gh-pages series was NEVER published — /bench, /bench-alloc and /bench-convergence stayed empty (zero github-action-benchmark commits on gh-pages, confirmed). Gate on tag refs instead (`startsWith(github.ref, 'refs/tags/v')`), matching the actual trigger: each release tag appends one data point; PR runs still render a comparison comment without polluting the series. Per-release rather than per-commit, by design (avoids running the heavy suites on every main merge). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the mutually-exclusive trigger/gate that left /bench, /bench-alloc, /bench-convergence empty. Trigger is v* tags + PRs; gate was refs/heads/main → never true. Now gated on
startsWith(github.ref,'refs/tags/v')(per-release publishing, the chosen policy). Workflow-only change.🤖 Generated with Claude Code