Repository navigation
Stabilize Windows CI and refresh project documentation - #34
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation and display-text updates are low risk, and the adjusted timing assertion remains bounded below natural process completion.
Review effort: Balanced
Findings: None
What changed in this PR
Stabilizes SkillView’s cancellation test under CI load and refreshes documentation to reflect the current implementation.
Changes:
- Raises the cancellation-test bound to 10 seconds, below the child’s 30-second natural exit.
- Corrects Doctor/help text and documents the fixed GitHub CLI minimum.
- Consolidates architecture guidance and clarifies testing, contribution, and branch-rule documentation.
| File | Description |
|---|---|
tests/SkillView.Tests/Subprocess/ProcessRunnerTests.cs |
Adds scheduling margin to cancellation timing. |
tests/SkillView.Tests/Cli/CliDispatcherHelpTests.cs |
Checks updated CLI compatibility wording. |
src/SkillView.Core/Cli/CliDispatcher.cs |
Corrects Doctor output, help text, and comments. |
site/docs.html |
Clarifies usage-guide coverage. |
docs/usage.md |
Updates Doctor descriptions and install options. |
docs/superpowers/specs/2026-05-20-skillview-workflow-first-ux-design.md |
Removes obsolete design notes. |
docs/runbooks/release-rollback.md |
Removes a version-specific deletion example. |
docs/reviews/adversarial-concurrency-resource-cancellation-audit-2026-08-28.md |
Removes historical audit notes. |
docs/decisions.md |
Removes outdated decision documentation. |
docs/architecture.md |
Adds a concise current architecture guide. |
CONTRIBUTING.md |
Refreshes architecture and build guidance. |
AGENTS.md |
Condenses testing and framework guidance. |
agent_docs/tui-pty-testing.md |
Updates startup detection guidance. |
agent_docs/running-tests.md |
Refreshes runner and automation-check instructions. |
.github/workflows/README.md |
Documents actual ProtectMain behavior. |
.github/copilot-instructions.md |
Clarifies when fresh reviews need manual requests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
gh skillsmoke check.Verification
dotnet restore --locked-modedotnet build --configuration Release --no-restoredotnet test --configuration Release --no-build --verbosity normal(830 passed on Windows ARM64)dotnet format SkillView.sln --no-restore --verify-no-changesnode --test .github/scripts/critical-dependencies.test.js .github/scripts/critical-dependency-assessment.test.js(9 passed)python site/build.pyandnode --check site/app.jsgit diff --checkThe failed Pages workflow was also rerun successfully; no workflow change was needed for GitHub's hosted-runner error.