Repository navigation
Fix inventory duplication, cleanup JSON, and PTY quit handling - #29
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fixes are consistent with repository conventions and include appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes inventory alias duplication, cleanup argument parsing, and PTY quit handling.
Changes:
- Canonicalizes Unix paths and caches case-sensitivity probes during inventory merging.
- Prevents bare
--candidatesfrom consuming--json. - Supports Ctrl+Alt+Q and expands TUI/PTY regression coverage.
| File | Description |
|---|---|
src/SkillView.Core/Inventory/LocalInventoryService.cs |
Resolves path aliases during merges. |
src/SkillView.Core/Cli/CliDispatcher.cs |
Corrects cleanup option parsing. |
src/SkillView.Core/Ui/SkillViewApp.cs |
Accepts Alt-modified Ctrl+Q. |
tests/SkillView.Tests/Inventory/LocalInventoryServiceMergeTests.cs |
Tests Unix alias deduplication. |
tests/SkillView.Tests/Cli/CliDispatcherParserTests.cs |
Tests bare candidate parsing. |
tests/SkillView.Tests/Ui/SkillViewAppTests.cs |
Tests Ctrl+Alt+Q detection. |
tests/SkillView.Tests/Ui/PtyStartupTests.cs |
Exercises PTY Escape/Ctrl+Q shutdown. |
tests/SkillView.IntegrationTests/Ui/SkillViewAppIntegrationTests.cs |
Covers rapid tab switching. |
AGENTS.md |
Records the PTY quit invariant. |
agent_docs/tui-pty-testing.md |
Documents headless PTY behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh skill listwith the filesystem scan, and reuse the case-sensitivity result per parent directory. This removes duplicate/varversus/private/varinstalls on macOS and avoids repeated directory probing.--jsonindependent of a barecleanup --candidatesoption.Verification
dotnet build --no-restore— cleandotnet test --no-build— 828 passedghcontract tests — 6 passeddotnet format SkillView.sln --no-restore --verify-no-changes— passed