Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no client QUIT on shutdown when it is not connected #47

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

DoobleD
Copy link
Contributor

@DoobleD DoobleD commented Dec 27, 2024

Not telling redis client to quit on shutdown when it is not connected.

Fixes the following critical error when using graceful_shutdown=true in smtp.ini and sending SIGINT to Haraka:

[NOTICE] [-] [core] SIGINT received
[INFO] [-] [server] Shutting down listeners
[INFO] [-] [server] Workers closed. Shutting down master process subsystems
[INFO] [-] [outbound] Shutting down temp fail queue
[INFO] [-] [plugins] Shutting down
[CRIT] [-] [core] Error: The client is closed
[CRIT] [-] [core]     at RedisSocket.quit (/opt/Haraka/node_modules/@redis/client/dist/lib/client/socket.js:70:19)
[CRIT] [-] [core]     at Commander.QUIT (/opt/Haraka/node_modules/@redis/client/dist/lib/client/index.js:260:71)
[CRIT] [-] [core]     at exports.shutdown (/opt/Haraka/node_modules/haraka-plugin-redis/index.js:153:24)
[CRIT] [-] [core]     at exports.shutdown_plugins (/opt/Haraka/plugins.js:240:43)
[CRIT] [-] [core]     at process.<anonymous> (/opt/Haraka/plugins.js:248:17)
[CRIT] [-] [core]     at process.emit (node:events:530:35)
[CRIT] [-] [core]     at Server._graceful (/opt/Haraka/server.js:237:21)
[CRIT] [-] [core]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Checklist:

  • docs updated
  • tests updated
  • Changes.md updated
  • package.json.version bumped

@DoobleD
Copy link
Contributor Author

DoobleD commented Jan 15, 2025

Just wondering if there's any update on this PR from reviewers?

@msimerson msimerson merged commit 24b726b into haraka:master Jan 26, 2025
6 checks passed
@msimerson msimerson mentioned this pull request Jan 27, 2025
msimerson added a commit that referenced this pull request Jan 27, 2025
- dep(eslint): upgrade to v9
- fix no client QUIT on shutdown when it is not connected (#47)
- fix missing error handlers on pi-watch and pi-karma redis clients
(#46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants