chore(haproxy): streamline service port configuration for flexibility #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the service port configuration in the HAProxy Helm chart to allow for more flexible and deterministic exposure of ports. This change introduces a new `exposedPorts` option in `values.yaml`, which, when specified, takes precedence over the default container ports for service exposure. This enhancement facilitates clearer and more customizable service definitions, catering to diverse deployment scenarios. Signed-off-by: Matthis Holleville <[email protected]>
|
@matthisholleville could you please share how you would go about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the service port configuration in the HAProxy Helm chart to allow for more flexible and deterministic exposure of ports. This change introduces a new
exposedPortsoption invalues.yaml, which, when specified, takes precedence over the default container ports for service exposure. This enhancement facilitates clearer and more customizable service definitions, catering to diverse deployment scenarios.In my case, this feature enables me to expose a port within the pods to configure
peerswithout exposing this port through my service.For my service, I only want to expose ports
80,443, and a few others.