Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior:
when you send a data notification without a
titleit will handle it as a "hidden" notification and only set an intent for the next app start (as there is no notification). BUT if the app is still running in the background it should still triggerdidReceiveMessage. Currently it doesn't as we setshowNotification = false.This PR:
Will return
trueso it still tries to calldidReceiveMessagebut still sets theti.firebase.messaging.hidden-notificationin case it was closed.Testing it with a Slack user at the moment
firebase.cloudmessaging-android-3.5.4.zip
Test:
didReceiveMessageis called