Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tables to adata.obs and subsetting #150

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

StasMakarchuk
Copy link
Contributor

  1. Added possibility to add custom csv table to adata.obs (for example cell types or clustering outputs). Make sure that csv file contatins column with correct cell identifiers and specify this column name
  2. Subsetting of xenium and spaceranger datasets - both in anndata and in image label file. We keep original cell ids, so subsetted set of cell ids (numbers) may have "gaps", like 1,2,3,5,9,....

@@ -1,5 +1,5 @@
#! /bin/sh
VERSION=0.5.2
VERSION=0.5.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this goes as 0.5.4, because 0.5.3 is the current version 🤔

@@ -1,5 +1,5 @@
FROM python:3.10
ARG BIOFORMATS2RAW="0.4.0"
ARG BIOFORMATS2RAW="0.7.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I ask to sneak in an additional version bump and make this 0.9.4 ?

and also update conda environment.yaml

@@ -5,7 +5,7 @@ import groovy.json.*
nextflow.enable.dsl=2

verbose_log = true
version = "0.5.2"
version = "0.5.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, I think it should be 0.5.4

Comment on lines +148 to +153
<<<<<<< HEAD
filter_obs_column (str): name of the column which will be used to perform data filtering
filter_obs_values (list): list of strings that has to pass the filter inside the column specified

=======
>>>>>>> f4cd6259b647c7919c15260dc0aa73e6fb161e11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a unresolved conflict?

# starting on v1.3 cell_id looks like "aaabinlp-1"
# pd.Categorical.codes converts them to int this is done manually at this step
# instead of reindex_anndata so we control what matches the label image
#just to make sure the column with name as index name column is not exists in adata.obs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

column does not exist in adata.obs


2023-05-18 09:30:16 (9.12 MB/s) - ‘v0.5.2.tar.gz’ saved [2835534]
2023-05-18 09:30:16 (9.12 MB/s) - ‘v0.5.3.tar.gz’ saved [2835534]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5.4

@@ -44,7 +44,7 @@ Using `curl`
.. code-block:: shell
:caption: Input

curl -L -o v0.5.2.tar.gz https://github.com/haniffalab/webatlas-pipeline/archive/refs/tags/v0.5.2.tar.gz
curl -L -o v0.5.3.tar.gz https://github.com/haniffalab/webatlas-pipeline/archive/refs/tags/v0.5.3.tar.gz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5.4

tar -xzvf ./v0.5.2.tar.gz
cd webatlas-pipeline-0.5.2
tar -xzvf ./v0.5.3.tar.gz
cd webatlas-pipeline-0.5.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5.4

Comment on lines +69 to +70
webatlas-pipeline-0.5.3/
webatlas-pipeline-0.5.3/.github/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5.4

Comment on lines +73 to +74
webatlas-pipeline-0.5.3/tests/input/simple_config.json
webatlas-pipeline-0.5.3/tests/test_class.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants