Merge pull request #349 from vicentegnz-contributions/feat/expiration…

…-manager-commiting-deletes-in-batches feat: expiration manager commiting deletes in batches
hangfire-postgres · Mar 2, 2024 · ffb9352 · ffb9352
2 parents 07c5815 + 20777f3
commit ffb9352
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/Hangfire.PostgreSql/ExpirationManager.cs b/src/Hangfire.PostgreSql/ExpirationManager.cs
@@ -77,10 +77,10 @@ public void Execute(CancellationToken cancellationToken)
         _logger.DebugFormat("Removing outdated records from table '{0}'...", table);
 
         UseConnectionDistributedLock(_storage, connection => {
-          using IDbTransaction transaction = connection.BeginTransaction();
           int removedCount;
           do
           {
+            using IDbTransaction transaction = connection.BeginTransaction();
             removedCount = connection.Execute($@"
                 DELETE FROM ""{_storage.Options.SchemaName}"".""{table}"" 
                 WHERE ""id"" IN (
@@ -95,14 +95,13 @@ DELETE FROM ""{_storage.Options.SchemaName}"".""{table}""
               continue;
             }
 
+            transaction.Commit();
             _logger.InfoFormat("Removed {0} outdated record(s) from '{1}' table.", removedCount, table);
 
             cancellationToken.WaitHandle.WaitOne(_delayBetweenPasses);
             cancellationToken.ThrowIfCancellationRequested();
           }
           while (removedCount != 0);
-
-          transaction.Commit();
         });
       }