Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme build badge (hotfix to master) #1445

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Sep 4, 2024

Context

This PR includes cherry-picked changes from:

that will fix the build: failing badge in the readme on master branch.

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Sep 4, 2024
@sequba sequba changed the title Hotfix: Fix readme build badge Fix readme build badge (hotfix to master) Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (a91f5d7) to head (0c2e214).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1445   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files         169      169           
  Lines       14430    14430           
  Branches     3101     3101           
=======================================
  Hits        14029    14029           
+ Misses        401      395    -6     
- Partials        0        6    +6     

see 3 files with indirect coverage changes

Copy link

github-actions bot commented Sep 4, 2024

Performance comparison of head (92ab78e) vs base (a91f5d7)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 517.57 |  529.1 | +2.23%
                                      Sheet B | 167.24 | 177.76 | +6.29%
                                      Sheet T | 147.62 | 154.23 | +4.48%
                                Column ranges | 518.81 | 527.66 | +1.71%
Sheet A:  change value, add/remove row/column |  16.29 |  16.04 | -1.53%
 Sheet B: change value, add/remove row/column |  140.6 |  147.7 | +5.05%
                   Column ranges - add column | 160.07 | 162.96 | +1.81%
                Column ranges - without batch | 489.63 | 487.23 | -0.49%
                        Column ranges - batch | 121.58 | 117.66 | -3.22%

* Add build-docs workflow

* Add environment variables necessary to build the docs with Node 20
@sequba sequba merged commit b89d2ce into master Sep 4, 2024
21 of 22 checks passed
@sequba sequba deleted the hotfix/fix-readme-build-badge branch September 4, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant