Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken EUIPO link in the branding page in the docs #1354

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Dec 15, 2023

Context

Link fixed

How did you test your changes?

local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1353

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba requested a review from evanSe December 15, 2023 10:05
@sequba sequba self-assigned this Dec 15, 2023
@sequba sequba linked an issue Dec 15, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Dec 15, 2023

Performance comparison of head (6a5582f) vs base (c74bb21)

                                     testName |   base |   head |   change
--------------------------------------------------------------------------
                                      Sheet A | 538.31 | 545.93 |   +1.42%
                                      Sheet B | 179.98 |  181.9 |   +1.07%
                                      Sheet T | 157.96 | 159.13 |   +0.74%
                                Column ranges | 555.32 | 563.57 |   +1.49%
Sheet A:  change value, add/remove row/column |     43 |     37 |  -13.95%
 Sheet B: change value, add/remove row/column |    283 |    271 |   -4.24%
                   Column ranges - add column |    169 |    182 |   +7.69%
                Column ranges - without batch |    518 |    424 |  -18.15%
                        Column ranges - batch |     97 |    208 | +114.43%

@sequba sequba merged commit 642506b into develop Dec 19, 2023
18 checks passed
@sequba sequba deleted the feature/issue-1353 branch December 19, 2023 10:14
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #1354 (88fef0b) into develop (c74bb21) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 88fef0b differs from pull request most recent head 6a5582f. Consider uploading reports for the commit 6a5582f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1354      +/-   ##
===========================================
- Coverage    97.35%   97.28%   -0.08%     
===========================================
  Files          169      169              
  Lines        14416    14425       +9     
  Branches      3016     3018       +2     
===========================================
- Hits         14035    14033       -2     
- Misses         381      392      +11     

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: broken EUIPO link in the branding page
2 participants