Skip to content

Provide more accurate info about running hanami in prod #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krzykamil
Copy link
Contributor

Based on this https://discourse.hanamirb.org/t/starting-hanami-in-production-environment/1273/2 we should make it more clear that due to the hanami server being just a thin wrapper on top of Rack::Server running the hanami server in production is not really supported and instead a more direct approach, like running puma with config file, is recommended.

Also removed the mentioned of RACK_ENV as recommended variable to use as it was only ever meant to define the default middleware.

Changed the order of the text too, to make it more explicit and visible, as I consider running the app in production env to be a crucial information.

@krzykamil krzykamil requested a review from timriley August 4, 2025 11:27
@timriley
Copy link
Member

timriley commented Aug 6, 2025

Thanks @krzykamil :) As it turns out, I'm not so certain we actually need these changes. I left some extra thoughts on the original forum thread. Let's continue the discussion there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants