Fix type signature of ExpectedException#except() #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the PECS guideline expect() should take Matcher<? super Throwable>. One test had to be adjusted so that the code still compiles: any(Expection.class) was replaced by instanceOf(Expection.class). Judging from the JavaDoc of both matchers the latter is anyway the better fitting one.
* use Java 7's diamond operator * harmonize generics * remove unused "generics handling" code
Closed
|
As a maintainer of JUnit, I support this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12 but in contrast to the proposed solution there it changes the signature of
ExpectedException#except(Matcher<?>)toexpect(Matcher<? super Throwable>).