-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add qq music and bilibili parser #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ping @halo-sigs/halo |
src/main/java/run/halo/editor/hyperlink/handler/HyperLinkDefaultParser.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Aziteee ,我这里有一个小的建议,有时间请看一看。
src/main/java/run/halo/editor/hyperlink/handler/HyperLinkParserConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
这个错误可能是因为我的建议导致的:#16 (comment)。 |
This reverts commit 65bea1e.
确实。已revert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
感谢贡献,这个功能将发布到 1.2.0 |
支持解析QQ音乐和哔哩哔哩的分享链接
由于原parser功能比较单一,所以有对代码进行重构,把请求的逻辑放到了parser里面