only sent serial output if connected

hall · Jun 18, 2023 · 20c0ee5 · 20c0ee5
1 parent 47e42dd
commit 20c0ee5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - filter file uploads by `.mxl` extension
 
+### Fixed
+
+- serial output no longer sent if cursor has not moved or port isn't connected
+
 ## [0.2.0] - 2023-06-15
 
 ### Changed

diff --git a/src/app/services/notes.service.ts b/src/app/services/notes.service.ts
@@ -100,7 +100,7 @@ export class NotesService {
 
   // write number to serial output
   async serialWrite(note: number) {
-    await this.writer.write(this.encoder.encode(note.toString() + '\n'));
+    if (this.port) await this.writer.write(this.encoder.encode(note.toString() + '\n'));
   }
 
   clear(): void {
@@ -195,8 +195,10 @@ export class NotesService {
             key.voice = voice.ParentVoice.VoiceId;
             key.finger = note.Fingering ? note.Fingering.value : '';
             key.grace = note.IsGraceNote;
-            key.required = true;
-            this.serialWrite(this.keys.indexOf(key));
+            if (!key.required) {
+              key.required = true;
+              this.serialWrite(this.keys.indexOf(key));
+            }
 
             // in case of tie, check that it is a start note
             if (typeof note.NoteTie === 'undefined' || note === note.NoteTie.StartNote) {