Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: add support for --api-versions #38

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

felixscheinost
Copy link
Contributor

I think including the option in chart2json and the helm module shouldn't cause any issues.

The only thing I am unsure about is whether builtins.map (customType: "${customType.group}/${customType.version}") (builtins.attrValues globalConfig.kubernetes.customTypes) is a good default value or whether some users will run into e.g. infinite recursion using that.

For me it worked fine though. I fetch CRDs using helm and put them into kubernetes.customResources using IFD.

@hall
Copy link
Owner

hall commented Oct 18, 2023

Thanks! Nice fix here; just tested (I had hardcoded a simple fix locally until I could get around to figuring out something better :sweat_smile) and it works for me as well.

The only thing I am unsure about is whether builtins.map (customType: "${customType.group}/${customType.version}") (builtins.attrValues globalConfig.kubernetes.customTypes) is a good default value or whether some users will run into e.g. infinite recursion using that.

Hopefully someone will open an issue in that case but I don't want to block on it.

@hall hall merged commit ea469ff into hall:main Oct 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants