helm: add support for --api-versions
#38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think including the option in
chart2json
and the helm module shouldn't cause any issues.The only thing I am unsure about is whether
builtins.map (customType: "${customType.group}/${customType.version}") (builtins.attrValues globalConfig.kubernetes.customTypes)
is a good default value or whether some users will run into e.g. infinite recursion using that.For me it worked fine though. I fetch CRDs using helm and put them into
kubernetes.customResources
using IFD.